Re: [PATCH v3 04/11] net: qrtr: support identical node ids

From: Mihai Moldovan
Date: Sun Jul 27 2025 - 13:34:18 EST


* On 7/27/25 16:40, Simon Horman wrote:
I tried again with the latest head,
commit 2fb2b9093c5d ("sleep_info: The synchronize_srcu() sleeps").
And in that case I no longer see the 1st warning, about locking.
I think this is what you saw too.

Exactly! Together with impossible condition warnings, but those are actually fine/intended.

This seems to a regression in Smatch wrt this particular case for this
code. I bisected Smatch and it looks like it was introduced in commit
d0367cd8a993 ("ranges: use absolute instead implied for possibly_true/false")
Oh, thank you very much. I suspected that I'm just missing a special script or option or even addition to Smash (given that Dan seems to have revamped its locking check code in 2020), especially since it seems to be so widely used in kernel development, but not a bug in the software itself.



Mihai

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature