Re: [PATCH v3 04/11] net: qrtr: support identical node ids

[Mihai Moldovan]

* On 7/24/25 15:08, Simon Horman wrote:
> [...]

Thank you for the reviews, to both you and Jakub.


> This will leak holding qrtr_nodes_lock.

It certainly does, will be fixed in v4.


> Flagged by Smatch.

I haven't used smatch before, and probably should do so going forward.

Curiously, a simple kchecker net/qrtr/ run did not warn about the locking issue 
(albeit it being obvious in the patch), while it did warn about the second issue 
with ret. Am I missing something?


> But ret is now 0, whereas before this patch it was -EINVAL.
> This seems both to be an unintentional side effect of this patch,
> and incorrect.

True. Will also fixed in v4.


Mihai

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature