Re: [PATCH net-next v10 05/15] net: phy: dp83822: Add support for phy_port representation

[Andrew Lunn]

> +#if IS_ENABLED(CONFIG_OF_MDIO)
> +		if (dp83822->fx_enabled && dp83822->fx_sd_enable)
> +			dp83822->fx_signal_det_low =
> +				device_property_present(&phydev->mdio.dev,
> +							"ti,link-loss-low");
> +
> +		/* ti,fiber-mode is still used for backwards compatibility, but
> +		 * has been replaced with the mdi node definition, see
> +		 * ethernet-port.yaml
> +		 */
> +		if (!dp83822->fx_enabled)
> +			dp83822->fx_enabled =
> +				device_property_present(&phydev->mdio.dev,
> +							"ti,fiber-mode");

Could be my grep fu is broken but:

~/linux$ grep -r fiber-mode arch/*
~/linux$ 

So it does not even appear to be used. If it is not used, do we have
to consider backwards compatibility?

Maybe consider marking the property deprecated and point to the new
binding?

	Andrew