Re: [EXTERNAL] Re: [PATCH v2] ALSA: hda: Add TAS2770 support

[Takashi Iwai]

On Sat, 26 Jul 2025 13:34:28 +0200,
Xu, Baojun wrote:
> 
> > 
> > ________________________________________
> > From: Takashi Iwai <tiwai@xxxxxxx>
> > Sent: 23 July 2025 22:40
> > To: Xu, Baojun
> > Cc: broonie@xxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; Ding, Shenghao; 13916275206@xxxxxxx; P O, Vijeth; linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: [EXTERNAL] Re: [PATCH v2] ALSA: hda: Add TAS2770 support
> > 
> > On Wed, 23 Jul 2025 16: 24: 23 +0200, Baojun Xu wrote: > > Add TAS2770 support in TI's HDA driver. And add hda_chip_id for > more products. Distinguish DSP and non-DSP in firmware > loading function. > > Signed-off-by: Baojun
> > ZjQcmQRYFpfptBannerStart
> > This message was sent from outside of Texas Instruments.
> > Do not click links or open attachments unless you recognize the source of this email and know the content is safe.
> > <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!vxdrHf3EPmdQig3vfxtoX0ga-ZW2grb4pJ-90xEaom-nVsHT8xHY3D2nK8v5mdWlEw0t3Q$>
> > Report Suspicious
> > 
> > ZjQcmQRYFpfptBannerEnd
> > 
> > On Wed, 23 Jul 2025 16:24:23 +0200,
> > Baojun Xu wrote:
> > >
> > > Add TAS2770 support in TI's HDA driver. And add hda_chip_id for
> > > more products. Distinguish DSP and non-DSP in firmware
> > > loading function.
> > >
> > > Signed-off-by: Baojun Xu <baojun.xu@xxxxxx>
> > 
> > Applied now, thanks.
> > 
> > 
> > BTW, is include/sound/tas2770-tlv.h used by any other driver?
> > (Also include/sound/tas2781-tlv.h).
> > 
> > If those are used only by tas2781-hda-i2s/spi drivers, the files can
> > be moved to sound/hda/codecs/side-codecs as local headers.
> > 
> > In general, include/sound is rather for public headers that are read
> > by multiple drivers in different places.
> 
> Thanks for the apply!
> Yes, include/sound/tasxxxx-tlv.h will also be used by other drivers
> (for example, sound/soc/codecs/tas2xxx-i2c.c)

OK, in that case, it's fine.


thanks,

Takashi