The function spacemit_ccu_reset_register() allocates memory for an
auxiliary device. If auxiliary_device_add() fails, it skips cleanup of
these resources, resulting in leaks.
Fix this by using the appropriate error handling path.
Fixes: 988543522ebd ("clk: spacemit: set up reset auxiliary devices")
Signed-off-by: Hendrik Hamerlinck <hendrik.hamerlinck@xxxxxxxxxxxx>
Reviewed-by: Yixun Lan <dlan@xxxxxxxxxx>
---
Changes in v2:
- Properly place the Fixes tip.
---
drivers/clk/spacemit/ccu-k1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/spacemit/ccu-k1.c b/drivers/clk/spacemit/ccu-k1.c
index 65e6de030717..5bb85e32c6cf 100644
--- a/drivers/clk/spacemit/ccu-k1.c
+++ b/drivers/clk/spacemit/ccu-k1.c
@@ -1059,7 +1059,7 @@ static int spacemit_ccu_reset_register(struct device *dev,
ret = auxiliary_device_add(adev);
if (ret) {
auxiliary_device_uninit(adev);
- return ret;
+ goto err_free_aux_id;
}
return devm_add_action_or_reset(dev, spacemit_adev_unregister, adev);