Re: [PATCH] riscv: Add sysctl to control discard of vstate during syscall

[Radim Krčmář]

2025-07-24T05:55:54+08:00, Vivian Wang <wangruikang@xxxxxxxxxxx>:
> On 7/19/25 11:39, Drew Fustini wrote:
>> From: Drew Fustini <dfustini@xxxxxxxxxxxxxxx>
>> Clobbering the vector registers can significantly increase system call
>> latency for some implementations. To mitigate this performance impact, a
>> policy mechanism is provided to administrators, distro maintainers, and
>> developers to control vector state discard in the form of a sysctl knob:
>
> So I had an idea: Is it possible to avoid repeatedly discarding the
> state on every syscall by setting VS to Initial after discarding, and
> avoiding discarding when VS is Initial? So:
>
> if (VS == Clean || VS == Dirty) {
>     clobber;
>     VS = Initial;
> }
>
> This would avoid this problem with syscall-heavy user programs while
> adding minimum overhead for everything else.

I think your proposal improves the existing code, but if a userspace is
using vectors, it's likely also restoring them after a syscall, so the
state would immediately get dirty, and the next syscall would again
needlessly clobber vector registers.

Preserving the vector state still seems better for userspaces that use
both vectors and syscalls.