Re: [PATCH v2] staging: rtl8723bs: fix if-statement alignment and line continuation in rtw_ap.c

From: Greg KH
Date: Fri Jul 25 2025 - 00:41:12 EST


On Thu, Jul 24, 2025 at 09:30:37PM +0200, Bruce Qin wrote:
> This patch fixes several style issues in a multiline if-statement:
>
> - Moved '&&' to the end of the previous line to follow logical continuation style
> - Fixed indentation to align with the opening parenthesis of the expression
> - Avoided ending a line with an open parenthesis '('
> - Moved closing ')' to the end of the last expression line (as suggested by the maintainer)
>
> These changes improve readability and conform to Linux kernel coding conventions.
> No functional changes.

Please wrap your changelog text at 72 columns, like checkpatch asks you
to.

>
> Signed-off-by: Bruce Qin <bqn9090@xxxxxxxxx>
> ---
> Changes in v2:
> - Moved closing ')' to the previous line as suggested by Greg Kroah-Hartman.
> - Thanks for the review and feedback!

You sent 3 copies of this "v2" patch, how do I know which one is
correct?

Please fix up and send a v3.

thanks,

greg k-h