Re: locking problems in iwlwifi? was Re: 6.16-rcX: crashing way too often on thinkpad X220

From: Waiman Long
Date: Thu Jul 24 2025 - 21:56:25 EST



On 7/24/25 6:21 PM, Thomas Gleixner wrote:
On Thu, Jul 24 2025 at 15:22, Waiman Long wrote:
On 7/24/25 3:07 PM, Pavel Machek wrote:
The lockdep warning just means that console_owner_lock is acquired both in
softirq context and in task context with interrupt enabled. That can leads
to deadlock. So the remedy is to always take console_owner_lock with
interrupt disabled, i.e. with
raw_spin_lock_irqsave/raw_spin_lock_irqrestore.
So you suspect problem is in the printk code?
This lockdep problem is likely unrelated to the IRQ flag problem
reported in the original email as it shouldn't affect the IRQ flag.
Wrong you are ... :)

Sorry for coming to a conclusion early without looking more deeply into the printk code. I do admit that printk() isn't an area that I know enough about.

Will look harder next time.

Thanks,
Longman