Re: [PATCH v3 08/14] drm/bridge: analogix_dp: Apply drm_bridge_connector helper

[Damon Ding]

Hi Heiko,

On 2025/7/24 21:00, Heiko Stübner wrote:
> Hi Damon,
>
> Am Donnerstag, 24. Juli 2025, 10:02:58 Mitteleuropäische Sommerzeit schrieb Damon Ding:
> > Apply drm_bridge_connector helper for Analogix DP driver.
> >
> > The following changes have been made:
> > - Apply drm_bridge_connector helper to get rid of &drm_connector_funcs
> >    and &drm_connector_helper_funcs.
> > - Remove unnecessary parameter struct drm_connector* for callback
> >    &analogix_dp_plat_data.attach.
> > - Remove &analogix_dp_device.connector.
> > - Convert analogix_dp_atomic_check()/analogix_dp_detect() to
> >    &drm_bridge_funcs.atomic_check()/&drm_bridge_funcs.detect().
> > - Split analogix_dp_get_modes() into &drm_bridge_funcs.get_modes() and
> >    &drm_bridge_funcs.edid_read().
> >
> > Signed-off-by: Damon Ding <damon.ding@xxxxxxxxxxxxxx>
>
> >   static enum drm_connector_status
> > -analogix_dp_detect(struct drm_connector *connector, bool force)
> > +analogix_dp_bridge_detect(struct drm_bridge *bridge)
> >   {
> > -	struct analogix_dp_device *dp = to_dp(connector);
> > +	struct analogix_dp_device *dp = to_dp(bridge);
> >   	enum drm_connector_status status = connector_status_disconnected;
> >   
> >   	if (dp->plat_data->panel)
>
> this needs an update to
>
>   static enum drm_connector_status
> -analogix_dp_bridge_detect(struct drm_bridge *bridge)
> +analogix_dp_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector)
>
> to follow Andy's patch [0] that got already applied to drm-misc-next
>
> Heiko
>
>
> [0] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5d156a9c3d5ea3dbec192121259dee2c2f938fa1

I will update it in the next version.

Best regards,
Damon