RE: [RFC PATCH V3 1/4] x86/Hyper-V: Not use hv apic driver when Secure AVIC is available

[Michael Kelley]

From: Tianyu Lan <ltykernel@xxxxxxxxx> Sent: Wednesday, July 23, 2025 12:03 PM
> 
> When Secure AVIC is available, AMD x2apic Secure
> AVIC driver should be selected and return directly
> in the hv_apic_init().

For the "RFC Patch v2" version of this patch, I had provided some comments
on the wording for the patch "Subject:" and for the commit message. [1] It
doesn't look like those comments were picked up. The comments
improve the use of English without changing any substantive information,
so I think they should be adopted.

[1] https://lore.kernel.org/linux-hyperv/CAMvTesAscN2MyqJXpcbwcXWC-6-en6U_c03M+2=zcMF0bLv4iw@xxxxxxxxxxxxxx/T/#m893e8cac0314e73ee4626d736c623e640b46ef5d

> 
> Signed-off-by: Tianyu Lan <tiala@xxxxxxxxxxxxx>
> ---
>  arch/x86/hyperv/hv_apic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c
> index bfde0a3498b9..1c48396e5389 100644
> --- a/arch/x86/hyperv/hv_apic.c
> +++ b/arch/x86/hyperv/hv_apic.c
> @@ -293,6 +293,9 @@ static void hv_send_ipi_self(int vector)
> 
>  void __init hv_apic_init(void)
>  {
> +       if (cc_platform_has(CC_ATTR_SNP_SECURE_AVIC))
> +               return;

This new code is indented with spaces instead of tabs. checkpatch.pl should
flag that.

> +
>  	if (ms_hyperv.hints & HV_X64_CLUSTER_IPI_RECOMMENDED) {
>  		pr_info("Hyper-V: Using IPI hypercalls\n");
>  		/*
> --
> 2.25.1
>