Re: [PATCH v2] selftests: firmware: Add details in error logging

[Shuah Khan]

On 7/20/25 12:21, Harshal Wadhwa wrote:
> On Mon, Jul 14, 2025 at 03:39:47PM -0600, Shuah Khan wrote:
> > On 7/14/25 15:26, Harshal wrote:
> > > Specify details in logs of failed cases
> >
> > How about changing the above to:
> >
> > Improve error messages adding details on failuires
> Will change this in next patch
>
> > >    	fd = open(sys_path, O_WRONLY);
> > >    	if (fd < 0)
> > > -		die("open failed: %s\n",
> > > +		die("open of sys_path failed: %s\n",
> >
> > Why not just use sys_path as a input parameter to die()?
> Sure, that's great. Is there a way to test these changes ?

The same way you tested your v2 patch? How did you test this
patch?

thanks,
-- Shuah