Re: locking problems in iwlwifi? was Re: 6.16-rcX: crashing way too often on thinkpad X220

[Waiman Long]

On 7/24/25 3:07 PM, Pavel Machek wrote:
> Hi!
>
> > > > > Can you please decode this, so we can see which part of that code it is?
> > > > And enable lockdep so that we can see where the interrupts were enabled?
> > > Enabled lockdep and got this one. It seems resume with bad wifi signal
> > > does it on 6.16...?
> > >
> > > Is it any good? Any decoding needed?
> > >
> > > ...
> > > [   32.361445] CPU2 is up
> > > [   32.361729] smpboot: Booting Node 0 Processor 3 APIC 0x3
> > > [   32.361982] Disabled fast string operations
> > > [   32.366800] CPU3 is up
> > > [   32.370186] ACPI: PM: Waking up from system sleep state S3
> > > [   32.393904] ACPI: EC: interrupt unblocked
> > > [   32.396000] sdhci-pci 0000:0d:00.0: MMC controller base frequency changed to 50Mhz.
> > > [   32.409738] ACPI: EC: event unblocked
> > > [   32.470808] iwlwifi 0000:03:00.0: Radio type=0x1-0x2-0x0
> > > [   32.687300] usb 2-1.4: reset full-speed USB device number 4 using ehci-pci
> > > [   32.758329] ata2: SATA link down (SStatus 0 SControl 300)
> > > [   32.758375] ata3: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
> > > [   32.762316] ata5: SATA link down (SStatus 0 SControl 300)
> > > [   32.764585] ata3.00: ACPI cmd f5/00:00:00:00:00:a0(SECURITY FREEZE LOCK) filtered out
> > > [   32.764593] ata3.00: ACPI cmd ef/10:03:00:00:00:a0(SET FEATURES) filtered out
> > > [   32.771931] sd 2:0:0:0: [sdb] Starting disk
> > > [   32.777439] ata3.00: ACPI cmd f5/00:00:00:00:00:a0(SECURITY FREEZE LOCK) filtered out
> > > [   32.777450] ata3.00: ACPI cmd ef/10:03:00:00:00:a0(SET FEATURES) filtered out
> > > [   32.782731] ata3.00: configured for UDMA/133
> > > [   32.786846] iwlwifi 0000:03:00.0: Radio type=0x1-0x2-0x0
> > > [   32.858513] usb 2-1.3: reset full-speed USB device number 3 using ehci-pci
> > > [   33.026331] usb 2-1.6: reset high-speed USB device number 5 using ehci-pci
> > > [   33.662583] psmouse serio1: synaptics: queried max coordinates: x [..5472], y [..4448]
> > > [   33.810033] PM: resume devices took 1.404 seconds
> > > [   33.841597] OOM killer enabled.
> > > [   33.841808] ACPI: \_SB_.PCI0.LPC_.EC__.BAT1: docking
> > > [   33.843280] Restarting tasks: Starting
> > > [   33.849066] ACPI: \_SB_.PCI0.LPC_.EC__.BAT1: Unable to dock!
> > > [   33.852744] Restarting tasks: Done
> > > [   33.888306] PM: suspend exit
> > > [   33.941831] Bluetooth: hci0: BCM: chip id 63
> > > [   33.944910] Bluetooth: hci0: BCM: features 0x07
> > > [   33.961985] Bluetooth: hci0: BCM20702A
> > > [   33.962628] Bluetooth: hci0: BCM20702A1 (001.002.014) build 0000
> > > [   33.970094] Bluetooth: hci0: BCM: firmware Patch file not found, tried:
> > > [   33.970993] Bluetooth: hci0: BCM: 'brcm/BCM20702A1-0a5c-21e6.hcd'
> > > [   33.971410] Bluetooth: hci0: BCM: 'brcm/BCM-0a5c-21e6.hcd'
> > > [   34.032198] Bluetooth: MGMT ver 1.23
> > > [   34.838285] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
> > > [   35.166235] ata1.00: ACPI cmd f5/00:00:00:00:00:a0(SECURITY FREEZE LOCK) filtered out
> > > [   35.167828] ata1.00: ACPI cmd ef/10:03:00:00:00:a0(SET FEATURES) filtered out
> > > [   35.206578] sd 0:0:0:0: [sda] Starting disk
> > > [   35.238578] ata1.00: ACPI cmd f5/00:00:00:00:00:a0(SECURITY FREEZE LOCK) filtered out
> > > [   35.240197] ata1.00: ACPI cmd ef/10:03:00:00:00:a0(SET FEATURES) filtered out
> > > [   35.278928] ata1.00: configured for UDMA/133
> > > [   35.613471] e1000e 0000:00:19.0 enp0s25: NIC Link is Down
> > > [   54.283825] wlp3s0: authenticate with c8:3a:35:f0:ad:f1 (local address=a0:88:b4:62:a7:30)
> > >
> > > [   54.284095] ================================
> > > [   54.284097] WARNING: inconsistent lock state
> > > [   54.284100] 6.16.0-rc7+ #305 Tainted: G S
> > > [   54.284104] --------------------------------
> > > [   54.284105] inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage.
> > > [   54.284108] wpa_supplicant/2940 [HC0[0]:SC0[0]:HE0:SE1] takes:
> > > [   54.284114] ffffffff86263fe0 (console_owner){+.?.}-{0:0}, at: console_lock_spinning_enable+0x3d/0x60
> > The lockdep warning just means that console_owner_lock is acquired both in
> > softirq context and in task context with interrupt enabled. That can leads
> > to deadlock. So the remedy is to always take console_owner_lock with
> > interrupt disabled, i.e. with
> > raw_spin_lock_irqsave/raw_spin_lock_irqrestore.
> So you suspect problem is in the printk code?

This lockdep problem is likely unrelated to the IRQ flag problem 
reported in the original email as it shouldn't affect the IRQ flag.

Cheers,
Longman