Re: [PATCH net-next 2/5] net: rpmsg-eth: Add basic rpmsg skeleton

[Krzysztof Kozlowski]

On 23/07/2025 10:03, MD Danish Anwar wrote:
> This patch introduces a basic RPMSG Ethernet driver skeleton. It adds

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> support for creating virtual Ethernet devices over RPMSG channels,
> allowing user-space programs to send and receive messages using a
> standard Ethernet protocol. The driver includes message handling,
> probe, and remove functions, along with necessary data structures.
> 


...

> +
> +/**
> + * rpmsg_eth_get_shm_info - Get shared memory info from device tree
> + * @common: Pointer to rpmsg_eth_common structure
> + *
> + * Return: 0 on success, negative error code on failure
> + */
> +static int rpmsg_eth_get_shm_info(struct rpmsg_eth_common *common)
> +{
> +	struct device_node *peer;
> +	const __be32 *reg;
> +	u64 start_address;
> +	int prop_size;
> +	int reg_len;
> +	u64 size;
> +
> +	peer = of_find_node_by_name(NULL, "virtual-eth-shm");


This is new ABI and I do not see earlier patch documenting it.

You cannot add undocumented ABI... but even if you documented it, I am
sorry, but I am pretty sure it is wrong. Why are you choosing random
nodes just because their name by pure coincidence is "virtual-eth-shm"?
I cannot name my ethernet like that?

Best regards,
Krzysztof