Re: [PATCH] x86/math64: handle #DE in mul_u64_u64_div_u64()
From: Oleg Nesterov
Date: Thu Jul 24 2025 - 04:12:55 EST
On 07/23, David Laight wrote:
>
> On Wed, 23 Jul 2025 11:38:25 +0200
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> >
> > to remove the conditional branch and additional variable. Your version
> > is probably beterr... But this is without WARN/BUG.
>
> I wish there was a way of doing a WARN_ONCE from asm with a single instruction.
> Then you could put one after your 2:
> Otherwise is it a conditional and a load of inlined code.
>
> > So, which version do you prefer?
>
> I wish I knew :-)
;-)
David, you understand this asm magic indefinitely better than me. Plus you are
working on the generic code. Can you send the patch which looks right to you?
I agree in advance with anything you do.
I got lost. Now I don't even understand if we want to add BUG and/or WARN into
mul_u64_u64_div_u64().
Thanks,
Oleg.