Re: [PATCH v5 1/2] pwm: mc33xs2410: add hwmon support

[Uwe Kleine-König]

Hello Dimitri,

On Wed, Jul 23, 2025 at 07:34:56PM +0200, Dimitri Fedrau via B4 Relay wrote:
> @@ -361,6 +373,10 @@ static int mc33xs2410_probe(struct spi_device *spi)
>  	if (ret < 0)
>  		return dev_err_probe(dev, ret, "Failed to add pwm chip\n");
>  
> +	adev = devm_auxiliary_device_create(dev, "hwmon", NULL);
> +	if (!adev)
> +		return dev_err_probe(dev, -ENODEV, "Failed to register hwmon device\n");

Not so nice that you have to make up an error code here. But that's not
your fault but devm_auxiliary_device_create()'s which returns NULL on
error instead of an error pointer.

> +
>  	return 0;
>  }

I applied the patch for the upcoming merge window to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

. Expecting the merge window to open on Sunday that's a bit tight
because I like drivers to be in next for a bit before they enter the
mainline. The major code change is in drivers/hwmon and I assume Guenter
is ok with me taking it for 6.17-rc1. If not, please object, then I'll
not send it to Linus and wait for the 6.18-rc1 PR.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature