Re: [PATCH v3] rust: remove spurious compiler_builtins dependents

From: Benno Lossin
Date: Wed Jul 23 2025 - 15:53:21 EST


On Wed Jul 23, 2025 at 5:18 PM CEST, Tamir Duberstein wrote:
> On Mon, Jul 21, 2025 at 8:25 AM Miguel Ojeda
> <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>>
>> On Sun, Jul 20, 2025 at 7:20 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
>> >
>> > Remove these dependency edges.
>>
>> I should have replied in previous versions: this is wrong -- the 3
>> changes each individually break the build.
>>
>> I guess that you are not cleaning everything in your tests before
>> testing the build.
>
> You're absolutely right, this patch is incorrect. I was indeed not
> blowing away build artifcats.

So is the `compiler_builtins` dependency correct for all crates?

---
Cheers,
Benno