Re: [PATCH v3 2/2] interconnect: qcom: Add Milos interconnect provider driver

[Georgi Djakov]

Hi Luca,

On 7/23/25 10:50 AM, Luca Weiss wrote:
> Hi Georgi,
>
> On Mon Jul 21, 2025 at 9:42 AM CEST, Luca Weiss wrote:
> > Hi Georgi,
> >
> > On Mon Jul 21, 2025 at 9:36 AM CEST, Georgi Djakov wrote:
> > > Hi Luca,
> > >
> > > On 7/9/25 4:14 PM, Luca Weiss wrote:
> > > > Add driver for the Qualcomm interconnect buses found in Milos based
> > > > platforms. The topology consists of several NoCs that are controlled by
> > > > a remote processor that collects the aggregated bandwidth for each
> > > > master-slave pairs.
> > > >
> > > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> > > > ---
> > > >    drivers/interconnect/qcom/Kconfig  |    9 +
> > > >    drivers/interconnect/qcom/Makefile |    2 +
> > > >    drivers/interconnect/qcom/milos.c  | 1837 ++++++++++++++++++++++++++++++++++++
> > > >    3 files changed, 1848 insertions(+)
> > > [..]
> > > > +
> > > > +static struct qcom_icc_node qhm_qup1 = {
> > > > +	.name = "qhm_qup1",
> > > > +	.channels = 1,
> > > > +	.buswidth = 4,
> > > > +	.qosbox = &qhm_qup1_qos,
> > > > +	.link_nodes = { &qns_a1noc_snoc, NULL },
> > > > +};
> > >
> > > It's very nice that you switched to the dynamic IDs, but please use the
> > > current style of links (like in v1), as the the NULL terminated lists
> > > are not merged yet. All the rest looks good!
> >
> > Is what's in todays linux-next a good base? Or what branch should I base
> > this on? But correct, I currently have v2 of dynamic ID patches in the
> > base for this.
> >
> > Also If I send the next revision by e.g. Wednesday can it still go into
> > 6.17? Just wondering how quick I need to work on this.
>
> In case you didn't receive my message on IRC, your icc-milos branch plus
> the following patch works fine:
> https://public.lucaweiss.eu/tmp/0001-fixup-interconnect-qcom-Add-Milos-interconnect-provi.patch

Thanks for the fixup!

BR,
Georgi