Re: [PATCH v7 3/6] rust: irq: add support for non-threaded IRQs and handlers

From: Daniel Almeida
Date: Wed Jul 23 2025 - 11:09:04 EST




> On 23 Jul 2025, at 11:35, Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> On 7/23/25 4:26 PM, Boqun Feng wrote:
>> On Wed, Jul 23, 2025 at 10:55:20AM -0300, Daniel Almeida wrote:
>> But sure, this and the handler pinned initializer thing is not a blocker
>> issue. However, I would like to see them resolved as soon as possible
>> once merged.
>
> I think it would be trivial to make the T an impl PinInit<T, E> and use a
> completion as example instead of an atomic. So, we should do it right away.
>
> - Danilo


I agree that this is a trivial change to make. My point here is not to postpone
the work; I am actually somewhat against switching to completions, as per the
reasoning I provided in my latest reply to Boqun. My plan is to switch directly
to whatever will substitute AtomicU32.

The switch to impl PinInit is fine.

— Daniel