Re: [PATCH net] net/sched: mqprio: fix stack out-of-bounds write in tc entry parsing

From: Vladimir Oltean
Date: Wed Jul 23 2025 - 10:32:11 EST


Hi Maher,

On Wed, Jul 23, 2025 at 02:01:52PM +0100, maher azz wrote:
> Hello,
>
> Thank you for taking the time to look into it. Should I remove the
> “reported by” tag? resend another patch or is it fine like that?
>
> Best regards,
> Maher

For an initial patch submission, the quality is reasonable. But it needs
improvement before it can be merged, and I recommend submitting a v2, no
earlier than 24 hours after the initial submission.

Some comments:

1. The "Author:" (in git; in the email it is the "From:" field) and last
"Signed-off-by:" tag need to coincide. In your case, they point to
the same person (you), but the formatting is different, so they don't
coincide. Please fix your "git config --global user.name" in the way
that Simon indicated.
2. Please don't top-post. Trim the quoted email to just the relevant
portions you're responding to, and respond below the quoted email.
3. Please configure your email client to respond only using plain-text
emails, no HTML.