Re: [PATCH net-next v3] ptp: add Alibaba CIPU PTP clock driver

[Wen Gu]

On 2025/7/22 17:13, Paolo Abeni wrote:
> On 7/17/25 9:57 AM, Wen Gu wrote:
> > +#define PTP_CIPU_BAR_0	0
> > +#define PTP_CIPU_REG(reg) \
> > +	offsetof(struct ptp_cipu_regs, reg)
>
> Minor nit: no need to use a multiple line macro above

Ok, will fix it.

> [...]
> > +static void ptp_cipu_clear_context(struct ptp_cipu_ctx *ptp_ctx)
> > +{
> > +	cancel_delayed_work_sync(&ptp_ctx->gen_timer);
> > +	cancel_delayed_work_sync(&ptp_ctx->mt_timer);
> > +	cancel_work_sync(&ptp_ctx->sync_work);
>
> You need to use the 'disable_' variant of the above helper, to avoid the
> work being rescheduled by the last iteration.

Ok, will use new helpers.

Thanks!
Wen Gu

> Other than that LGTM, thanks.
>
> Paolo