RE: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)
From: K, Kiran
Date: Wed Jul 23 2025 - 08:44:20 EST
Hi Luiz,
>-----Original Message-----
>From: Salah Triki <salah.triki@xxxxxxxxx>
>Sent: Thursday, July 17, 2025 8:55 AM
>To: Marcel Holtmann <marcel@xxxxxxxxxxxx>; Luiz Augusto von Dentz
><luiz.dentz@xxxxxxxxx>; linux-bluetooth@xxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx
>Cc: salah.triki@xxxxxxxxx
>Subject: [PATCH] Bluetooth: btintel_pcie: Drop pci_set_drvdata(pdev, NULL)
>
>Drop pci_set_drvdata(pdev, NULL) in the remove function of the pci driver
>since it is useless, the data is not accessible when the driver is removed.
>
>Signed-off-by: Salah Triki <salah.triki@xxxxxxxxx>
Tested-by: Kiran K <kiran.k@xxxxxxxxx>
>---
> drivers/bluetooth/btintel_pcie.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>index e1c688dd2d45..28fa4ca3199a 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -2339,8 +2339,6 @@ static void btintel_pcie_remove(struct pci_dev
>*pdev)
> btintel_pcie_free(data);
>
> pci_clear_master(pdev);
>-
>- pci_set_drvdata(pdev, NULL);
> }
>
> #ifdef CONFIG_DEV_COREDUMP
>--
>2.43.0
>
Thanks,
Kiran