Re: [PATCH v4 2/2] arm64: dts: qcom: qcs615-ride: add WiFi/BT nodes

[Dmitry Baryshkov]

On Wed, Jul 23, 2025 at 10:02:36AM +0800, Yu Zhang(Yuriy) wrote:
> 
> 
> On 7/23/2025 1:36 AM, Dmitry Baryshkov wrote:
> > On 22/07/2025 18:58, Yu Zhang(Yuriy) wrote:
> > > 
> > > 
> > > On 7/19/2025 6:13 PM, Dmitry Baryshkov wrote:
> > > > On Mon, Jul 07, 2025 at 10:51:06AM +0800, Yu Zhang(Yuriy) wrote:
> > > > > Add a node for the PMU module of the WCN6855 present on the qcs615 ride
> > > > > board. Assign its LDO power outputs to the existing WiFi/BT module.
> > > > 
> > > > 
> > > > What is "existing WiFI/BT module"? There is no module in the DT. Not to
> > > > mention that PMU is a part of the WCN6855.
> > > > 
> > > > > 
> > > > > Signed-off-by: Yu Zhang(Yuriy) <yu.zhang@xxxxxxxxxxxxxxxx>
> > > > > ---
> > > > >   arch/arm64/boot/dts/qcom/qcs615-ride.dts | 135
> > > > > +++++++++++++++++++ + +++++++++++
> > > > >   1 file changed, 135 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > b/arch/arm64/ boot/dts/qcom/qcs615-ride.dts
> > > > > index 011f8ae077c256f079ce1b07720374a9bf721488..2df8e7e3c1d3b6d6353a6753b8387c7411edd927
> > > > > 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
> > > > > @@ -18,6 +18,7 @@ aliases {
> > > > >           mmc0 = &sdhc_1;
> > > > >           mmc1 = &sdhc_2;
> > > > >           serial0 = &uart0;
> > > > > +        serial1 = &uart7;
> > > > >       };
> > > > >       chosen {
> > > > > @@ -47,6 +48,85 @@ regulator-usb2-vbus {
> > > > >           enable-active-high;
> > > > >           regulator-always-on;
> > > > >       };
> > > > > +
> > > > > +    vreg_conn_1p8: vreg_conn_1p8 {
> > > > 
> > > > No improvement. Please try again.
> > > > 
> > > you mean should be "vreg_conn_1p8: vreg-conn-1p8",right? I'll update
> > > it,
> > 
> > What is the node name for the previous regulator device? Anything
> > preventing you from following the pattern?
> > 
> Do you mean the prefix 'regulator'?
> I just want to keep 'vreg_conn_1p8' and 'vreg_conn_pa' the same as in
> sa8775p-ride.dtsi, because they're using the same module.

That's a different device. Please use the style of the file that you are
patching.

> 
> > > thanks.>> +        compatible = "regulator-fixed";
> > > > > +        regulator-name = "vreg_conn_1p8";
> > > > > +        startup-delay-us = <4000>;
> > > > > +        enable-active-high;
> > > > > +        gpio = <&pm8150_gpios 1 GPIO_ACTIVE_HIGH>;
> > > > > +    };
> > > > > +
> > > > > +    vreg_conn_pa: vreg_conn_pa {
> > > > > +        compatible = "regulator-fixed";
> > > > > +        regulator-name = "vreg_conn_pa";
> > > > > +        startup-delay-us = <4000>;
> > > > > +        enable-active-high;
> > > > > +        gpio = <&pm8150_gpios 6 GPIO_ACTIVE_HIGH>;
> > > > > +    };
> > > > > +
> > > > 
> > > 
> > 
> > 
> 

-- 
With best wishes
Dmitry