Re: [PATCH 00/25] Enable H.264/H.265 encoder support and fixes in common code

[Bryan O'Donoghue]

On 23/07/2025 07:40, Dikshita Agarwal wrote:
> On 7/4/2025 1:23 PM, Dikshita Agarwal wrote:
> > Hi All,
> >
> > This patch series adds support for H.264 and H.265 encoder in iris
> > driver and includes a few fixes and cleanup in the common code that were
> > identified during encoder bring-up process.
> >
> > The changes include:
> > - Enabling support for H.264 and H.265 encoding.
> > - Fixes and improvements in shared componenets used by both encoder and
> > decoder paths.
> > - Ensuring compatibility and stability with the existing decoder flow.
> >
> > All patches have been tested with v4l2-compliance, v4l2-ctl and
> > Gstreamer on SM8250 and SM8550 for encoder, at the same time ensured
> > that the existing decoder functionality remains uneffected.
>
> @bryan/@vikash
> do you have any further comments on this series, I have few smatch/cocci
> fixes which I plan to push with v2.
> If you have any comments, I can address them as well in v2.
>
> Thanks,
> Dikshita

Will review this week.

I have it stacked on a Hamoa tree and it passes v4l2-compliance but, I 
haven't put it through an actual test of the encoder yet.

Will do ASAP.

---
bod