Re: [PATCH RESEND] brcmfmac: Add an error log for brcmf_sdiod_ramrw()

From: Arend van Spriel
Date: Wed Jul 23 2025 - 04:25:10 EST


On 4/14/2025 9:42 AM, Wentao Liang wrote:
The function brcmf_sdio_buscore_activate() calls the function
brcmf_sdiod_ramrw(), but does not check its return value. Log
the error message to prevent silent failure if the function fails.

Johannes delegated this to me in patchwork so catching up on what was already forgotten. Sorry about that.

The likelihood that writing the reset vector in device memory fails is next to nothing, because this step is done after we have written the firmware and nvram into device memory. Any issue accessing device memory would have cause a failure in those steps. So I suggest to drop this patch.

Regards,
Arend