Re: [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195 compatible and update clock nodes

[AngeloGioacchino Del Regno]

Il 23/07/25 09:33, Macpaul Lin (林智斌) ha scritto:
> On Tue, 2025-07-22 at 11:39 +0200, AngeloGioacchino Del Regno wrote:
> > External email : Please do not click links or open attachments until
> > you have verified the sender or the content.
>
> [snip...]
>
> > The unipro mp_bclk really is the ufs-sap clock; besides, the standard
> > has clocks
> > for both TX and RX symbols - and also MT8195 (and also MT6991,
> > MT8196, and others)
> > UFS controller do have both TX and RX symbol clocks.
> >
> > Besides, you're also missing the crypto clocks for UFS, which brings
> > the count to
> > 12 total clocks for MT8195.
> >
> > Please, look at my old submission, which actually fixes the
> > compatibles other than
> > adding the right clocks for all UFS controllers in MediaTek
> > platforms.
> >
> > https://lore.kernel.org/all/20240612074309.50278-1-angelogioacchino.delregno@xxxxxxxxxxxxx/
> >
> > I want to take the occasion to remind everyone that my fixes were
> > discarded because
> > the MediaTek UFS driver maintainer wants to keep the low quality of
> > the driver in
> > favor of easier downstream porting - which is *not* in any way
> > adhering to quality
> > standards that the Linux community deserves.
>
> Oops, it is sad to hear that.
> MediaTek will raise an internal discussion and hope
> we could get the more specific requirements back to you soon.

Thanks for that.

Cheers,
Angelo