Re: [PATCH v2 1/5] dt-bindings: mfd: khadas-mcu: add new compatible for Khadas Edge 2

[Krzysztof Kozlowski]

On Tue, Jul 22, 2025 at 03:38:11PM +0300, muhammed.efecetin.67@xxxxxxxxx wrote:
> From: Muhammed Efe Cetin <efectn@xxxxxxxxxxxxxx>
> 
> Add new khadas,mcu-v2 compatible which is going to be used with Khadas
> Edge 2 and potantially new Khadas boards like Vim4, using the same fan
> control register.
> 
> Signed-off-by: Muhammed Efe Cetin <efectn@xxxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/khadas,mcu.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/khadas,mcu.yaml b/Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
> index 084960fd5..fd57ed92c 100644
> --- a/Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
> +++ b/Documentation/devicetree/bindings/mfd/khadas,mcu.yaml
> @@ -11,13 +11,14 @@ maintainers:
>  
>  description: |
>    Khadas embeds a microcontroller on their VIM and Edge boards adding some
> -  system feature as PWM Fan control (for VIM2 rev14 or VIM3), User memory
> +  system feature as PWM Fan control (for VIM2 rev14, VIM3, Edge2), User memory
>    storage, IR/Key resume control, system power LED control and more.
>  
>  properties:
>    compatible:
>      enum:
> -      - khadas,mcu # MCU revision is discoverable
> +      - khadas,mcu    # Used by VIM2 rev14, VIM3
> +      - khadas,mcu-v2 # Used by Edge2

You need documented versioning (provide a link/datasheet). Otherwise you
should use compatibles specific to the hardware, e.g. edge2

Best regards,
Krzysztof