Re: [PATCH v2 2/2] binder: Use seq_buf in binder_alloc kunit tests

From: Kees Cook
Date: Wed Jul 23 2025 - 03:33:38 EST


On Tue, Jul 22, 2025 at 04:45:07PM -0700, Tiffany Yang wrote:
> Replace instances of snprintf with seq_buf functions, as suggested by
> Kees [1].
>
> [1] https://lore.kernel.org/all/202507160743.15E8044@keescook/
>
> Fixes: d1934ed9803c ("binder: encapsulate individual alloc test cases")
> Suggested-by: Kees Cook <kees@xxxxxxxxxx>
> Cc: Joel Fernandes <joelagnelf@xxxxxxxxxx>
> Signed-off-by: Tiffany Yang <ynaffit@xxxxxxxxxx>
> ---
> This patch is based on top of char-misc-next.
> ---
> drivers/android/tests/binder_alloc_kunit.c | 46 ++++++++++------------
> 1 file changed, 21 insertions(+), 25 deletions(-)

Yay, always nice to see using an alternative API results in fewer lines! :)

Reviewed-by: Kees Cook <kees@xxxxxxxxxx>

--
Kees Cook