Re: [tip: irq/core] genirq: Move irq_wait_for_poll() to call site
From: Ingo Molnar
Date: Wed Jul 23 2025 - 02:22:42 EST
Two minor nits:
* tip-bot2 for Thomas Gleixner <tip-bot2@xxxxxxxxxxxxx> wrote:
> + /* Might have been disabled in meantime */
> + return !irqd_irq_disabled(&desc->irq_data) && desc->action;
This has a (pre-existing) spelling mistake:
s/in meantime
/in the meantime
> + if (WARN_ONCE(irq_poll_cpu == smp_processor_id(),
> + "irq poll in progress on cpu %d for irq %d\n",
> + smp_processor_id(), desc->irq_data.irq))
And we usually capitalize these:
s/on cpu
/on CPU
s/irq poll
/IRQ poll
Just like in the surrounding comments:
> - * If the poll runs on this CPU, then we yell loudly and return
Thanks,
Ingo