Re: [PATCH v2 2/2] checkpatch: enforce 12-char SHA for Fixes tags

From: Greg Kroah-Hartman
Date: Wed Jul 23 2025 - 01:19:05 EST


On Tue, Jul 22, 2025 at 11:02:57PM -0400, Ignacio Peña wrote:
> The kernel documentation recommends 12 character SHA-1 hashes
> for Fixes tags. The current code allows 12-40 characters but
> we should enforce exactly 12 for consistency.
>
> The regex is changed from {12,40} to {12} and the warning
> message updated accordingly.
>
> Link: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ignacio Peña <ignacio.pena87@xxxxxxxxx>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

No list of what changed from v1?

And also, why make this change at all? 12+ is fine, I haven't seen
people use huge values in the past, have you?

thanks,

greg k-h