Re: [PATCH bpf-next 2/2] umd: Remove usermode driver framework

[Eric W. Biederman]

Christoph Hellwig <hch@xxxxxx> writes:

> On Mon, Jul 21, 2025 at 08:51:22AM -0700, Alexei Starovoitov wrote:
>> On Mon, Jul 21, 2025 at 2:05 AM Thomas Weißschuh
>> <thomas.weissschuh@xxxxxxxxxxxxx> wrote:
>> >
>> > The code is unused since commit 98e20e5e13d2 ("bpfilter: remove bpfilter"),
>> > remove it.
>> 
>> Correct, but we have plans to use it.
>> Since it's not causing any problems we prefer to keep it
>> to avoid reverting the removal later.
>
> Plans to eventually use something are no reason to keep code that's been
> unused for almost 2 years around.  Unless the removal would conflict with
> currently queued up in linux-next code it is always better to just drop
> it and reinstate it when (or rather usually IFF) it is used again.

I wonder if those are the same plans that existed in June of 2020 when I
split out the usermode driver code from user mode helper?

As far as I know this code has never been seriously used, so I am in
favor of simplifying the maintenance burden.

Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>

Eric