Re: [PATCH bpf-next v2 3/3] bpftool: Add bash completion for token argument

[Quentin Monnet]

2025-07-23 00:35 UTC+0800 ~ Tao Chen <chen.dylane@xxxxxxxxx>
> 在 2025/7/22 23:02, Quentin Monnet 写道:
>> 2025-07-22 20:09 UTC+0800 ~ Tao Chen <chen.dylane@xxxxxxxxx>
>>> This commit updates the bash completion script with the new token
>>> argument.
>>> $ bpftool
>>> batch       cgroup      gen         iter        map        
>>> perf        struct_ops
>>> btf         feature     help        link        net        
>>> prog        token
>>
>>
>> This is a terrible example, offering "token" as completion for just
>> "bpftool [tab]" works without this patch :) The main commands are parsed
>> from the output of "bpftool help" so it should work after your first
>> patch. In this one, we add "list", "show" and "help" for completing
>> "bpftool token [tab]".
>>
> 
> As you said, how about this one? I will change it in v3, thanks.
>     $ bpftool token
>     help  list  show

Yes, perfect