Re: [PATCH v3 3/6] x86: Reorder headers alphabetically
From: Sean Christopherson
Date: Tue Jul 22 2025 - 10:28:00 EST
On Tue, Jul 22, 2025, Ahmed S. Darwish wrote:
> Multiple x86 source files use the cpuid_*() macros, but implicitly
> include the main CPUID API header.
>
> Sort their include lines so that <asm/cpuid/api.h> can be explicitly
> included next.
>
> Signed-off-by: Ahmed S. Darwish <darwi@xxxxxxxxxxxxx>
> ---
> arch/x86/boot/startup/sme.c | 8 +--
> arch/x86/coco/tdx/tdx.c | 5 +-
> arch/x86/events/amd/uncore.c | 14 +++---
> arch/x86/events/zhaoxin/core.c | 11 ++---
> arch/x86/kernel/apic/apic.c | 70 +++++++++++++--------------
> arch/x86/kernel/cpu/amd.c | 25 +++++-----
> arch/x86/kernel/cpu/mce/core.c | 62 ++++++++++++------------
> arch/x86/kernel/cpu/microcode/amd.c | 12 ++---
> arch/x86/kernel/cpu/microcode/core.c | 22 ++++-----
> arch/x86/kernel/cpu/microcode/intel.c | 11 +++--
> arch/x86/kernel/cpu/mshyperv.c | 28 ++++++-----
> arch/x86/kernel/cpu/resctrl/core.c | 5 +-
> arch/x86/kernel/cpu/scattered.c | 2 +-
> arch/x86/kernel/cpu/topology_common.c | 2 +-
> arch/x86/kernel/cpu/vmware.c | 13 ++---
> arch/x86/kernel/jailhouse.c | 9 ++--
> arch/x86/kernel/kvm.c | 35 +++++++-------
> arch/x86/kernel/paravirt.c | 28 +++++------
> arch/x86/kvm/mmu/mmu.c | 56 ++++++++++-----------
> arch/x86/kvm/svm/sev.c | 25 +++++-----
> arch/x86/kvm/svm/svm.c | 50 +++++++++----------
> arch/x86/kvm/vmx/pmu_intel.c | 6 ++-
> arch/x86/kvm/vmx/sgx.c | 2 +-
> arch/x86/kvm/vmx/vmx.c | 18 +++----
If this series is squeezed into Linus' tree just before rc1, I suppose I'm fine
with this patch. But I am NOT providing an ack for general inclusion, because
the potential for pain is not worth the warm fuzzies we get by having sorted
includes.