Re: [PATCH v4 1/2] dt-bindings: regulator: Add Richtek RTR5133 Support

From: Mark Brown
Date: Tue Jul 22 2025 - 07:54:28 EST


On Tue, Jul 22, 2025 at 11:04:51AM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2025 10:34, jeff_chang@xxxxxxxxxxx wrote:

> > + base:
> > + type: object
> > + $ref: regulator.yaml#
> > + unevaluatedProperties: false
> > + description:
> > + Properties for base regulator which control force-off base circuit.
> > + Base circuit is the power source for LDO1~LDO6. Disabling it will
> > + reduce IQ for Chip.

> I don't understand what this regulator is for. Your example is also
> incomplete - missing min/max constraints like voltage.

> Explain, what is this output pin? I already asked for explanations. I
> have diagram in front of me, so explain precisely instead of sending THE
> SAME again - which pin is it?

It's the top level supply for the chip, it's likely not externally
visible and sounds like it's just an on/off switch rather than
regulating voltages. This seems fairly clear with domain knowledge.

Attachment: signature.asc
Description: PGP signature