Re: [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe

[Vadim Fedorenko]

On 22/07/2025 04:02, Yibo Dong wrote:
> On Mon, Jul 21, 2025 at 02:30:40PM +0100, Vadim Fedorenko wrote:
> > On 21/07/2025 12:32, Dong Yibo wrote:
> > > Add build options and doc for mucse.
> > > Initialize pci device access for MUCSE devices.
> > >
> > > Signed-off-by: Dong Yibo <dong100@xxxxxxxxx>
> > > ---

[...]

> > > +
> > > +struct mucse {
> > > +	struct net_device *netdev;
> > > +	struct pci_dev *pdev;
> > > +	/* board number */
> > > +	u16 bd_number;
> > > +
> > > +	char name[60];
> > > +};
> > > +
> > > +/* Device IDs */
> > > +#ifndef PCI_VENDOR_ID_MUCSE
> > > +#define PCI_VENDOR_ID_MUCSE 0x8848
> > > +#endif /* PCI_VENDOR_ID_MUCSE */
> >
> > this should go to include/linux/pci_ids.h without any ifdefs
>
> Got it, I will update this.

As Andrew said, my suggestion is not fully correct, if you are not going
to implement more drivers, keep PCI_VENDOR_ID_MUCSE in rnpgbe.h but
without #ifdef


> > > +
> > > +#define PCI_DEVICE_ID_N500_QUAD_PORT 0x8308
> > > +#define PCI_DEVICE_ID_N500_DUAL_PORT 0x8318
> > > +#define PCI_DEVICE_ID_N500_VF 0x8309
> > > +#define PCI_DEVICE_ID_N210 0x8208
> > > +#define PCI_DEVICE_ID_N210L 0x820a
> > > +
> > > +#endif /* _RNPGBE_H */
> >
> > [...]