Re: [PATCH net] net: core: Fix the loop in default_device_exit_net()

From: Eric Dumazet
Date: Tue Jul 22 2025 - 02:52:20 EST


On Fri, Jul 18, 2025 at 1:21 PM Haiyang Zhang
<haiyangz@xxxxxxxxxxxxxxxxxxx> wrote:
>
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>
> The loop in default_device_exit_net() won't be able to properly detect the
> head then stop, and will hit NULL pointer, when a driver, like hv_netvsc,
> automatically moves the slave device together with the master device.
>
> To fix this, add a helper function to return the first migratable netdev
> correctly, no matter one or two devices were removed from this net's list
> in the last iteration.
>
> Cc: stable@xxxxxxxxxxxxxxx # 5.4+

We (network maintainers) prefer a Fixes: tag, so that we can look at
the blamed patch, rather than trusting your '5.4' hint.

Without a Fixes tag, you are forcing each reviewer to do the
archeology work, and possibly completely miss your point.