RE: [PATCH v8 1/5] x86/sgx: Introduce a counter to count the sgx_(vepc_)open()

[Reshetova, Elena]

> -----Original Message-----
> From: Hansen, Dave <dave.hansen@xxxxxxxxx>
> Sent: Monday, July 21, 2025 7:48 PM
> To: Reshetova, Elena <elena.reshetova@xxxxxxxxx>
> Cc: jarkko@xxxxxxxxxx; seanjc@xxxxxxxxxx; Huang, Kai
> <kai.huang@xxxxxxxxx>; mingo@xxxxxxxxxx; linux-sgx@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; Mallick, Asit K
> <asit.k.mallick@xxxxxxxxx>; Scarlata, Vincent R <vincent.r.scarlata@xxxxxxxxx>;
> Cai, Chong <chongc@xxxxxxxxxx>; Aktas, Erdem <erdemaktas@xxxxxxxxxx>;
> Annapurve, Vishal <vannapurve@xxxxxxxxxx>; Bondarevska, Nataliia
> <bondarn@xxxxxxxxxx>; Raynor, Scott <scott.raynor@xxxxxxxxx>
> Subject: Re: [PATCH v8 1/5] x86/sgx: Introduce a counter to count the
> sgx_(vepc_)open()
> 
> On 7/15/25 05:40, Elena Reshetova wrote:
> > +int sgx_inc_usage_count(void)
> > +{
> > +	sgx_usage_count++;
> > +	return 0;
> > +}
> > +
> > +void sgx_dec_usage_count(void)
> > +{
> > +	sgx_usage_count--;
> > +}
> 
> Gah.
> 
> I know this gets fixed up later in the series with the mutex, but this
> code is broken and racy until that point.
> 
> I'd rather this do _nothing_:
> 
> 	int sgx_inc_usage_count(void)
> 	{
> 		return 0;
> 	}
> 
> than a foo++ which just plain doesn't work.

Sure, I can fix it also in v9. 

Best Regards,
Elena.