Re: [PATCH] lib/crypto: tests: Annotate worker to be on stack

[Eric Biggers]

On Mon, Jul 21, 2025 at 04:19:17PM -0700, Guenter Roeck wrote:
> The following warning traceback is seen if object debugging is enabled
> with the new crypto test code.
> 
> ODEBUG: object 9000000106237c50 is on stack 9000000106234000, but NOT annotated.
> ------------[ cut here ]------------
> WARNING: lib/debugobjects.c:655 at lookup_object_or_alloc.part.0+0x19c/0x1f4, CPU#0: kunit_try_catch/468
> ...
> 
> This also results in a boot stall when running the code in qemu:loongarch.
> 
> Initializing the worker with INIT_WORK_ONSTACK() fixes the problem.
> 
> Cc: Eric Biggers <ebiggers@xxxxxxxxxx>
> Fixes: 950a81224e8b ("lib/crypto: tests: Add hash-test-template.h and gen-hash-testvecs.py")
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
>  lib/crypto/tests/hash-test-template.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

Thanks!

I also added the following to the debugging kconfig that I use:

    CONFIG_DEBUG_OBJECTS_FREE=y
    CONFIG_DEBUG_OBJECTS_TIMERS=y
    CONFIG_DEBUG_OBJECTS_WORK=y
    CONFIG_DEBUG_OBJECTS_RCU_HEAD=y
    CONFIG_DEBUG_OBJECTS_PERCPU_COUNTER=y

- Eric