Re: [PATCH net-next V3 3/3] net/mlx5e: Remove duplicate mkey from SHAMPO header

From: Jacob Keller
Date: Mon Jul 21 2025 - 19:45:07 EST




On 7/21/2025 12:13 AM, Tariq Toukan wrote:
> From: Lama Kayal <lkayal@xxxxxxxxxx>
>
> SHAMPO structure holds two variations of the mkey, which is unnecessary,
> a duplication that's repeated per rq.
>
> Remove duplicate mkey information and keep only one version, the one
> used in the fast path, rename field to reflect field type clearly.
>
> Signed-off-by: Lama Kayal <lkayal@xxxxxxxxxx>
> Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>
> ---

No reason to waste the bytes if you never need the host-endian mkey anyways.

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature