Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

[Marek Vasut]

On 7/21/25 11:28 AM, Tudor Ambarus wrote:

Hi,

> > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> > index 63a93c9eb917..dcb6c9ec862a 100644
> > --- a/drivers/mtd/spi-nor/winbond.c
> > +++ b/drivers/mtd/spi-nor/winbond.c
> > @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
> >   		.id = SNOR_ID(0xef, 0x80, 0x20),
> >   		.name = "w25q512nwm",
> >   		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> > +	}, {
> > +		.id = SNOR_ID(0xef, 0x8a, 0x1a),
> > +		.name = "w77q51nw",
>
> we concluded that the name is not relevant, as there can be flashes
> that update their name or worse, entirely different flashes that use
> the same flash ID. So please add the name as a comment, above the flash
> definition. See recent flash additions.
>
> Also, we introduced some minimum testing requirements, so that we make
> sure that the flash was tested at the time of submission and also to
> save the dtb database in case other flashes reuse the flash ID, or
> different flavors appear, etc. Please do the tests described at:
> https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements
Should all be part of V2 I just posted, thanks .