Re: [PATCH RESEND 1/2] ucount: Fix atomic_long_inc_below argument typei()
From: Uros Bizjak
Date: Mon Jul 21 2025 - 13:49:27 EST
Sorry, patches in this series have some problems in their description,
please expect v2.
Uros.
On Mon, Jul 21, 2025 at 7:42 PM Uros Bizjak <ubizjak@xxxxxxxxx> wrote:
>
> The type of u argument of atomic_long_inc_below() should be long
> to avoid unwanted truncation to int.
>
> Fixes: f9c82a4ea89c ("Increase size of ucounts to atomic_long_t")
> Signed-off-by: Uros Bizjak <ubizjak@xxxxxxxxx>
> Reviewed-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxx>
> Cc: Alexey Gladkov <legion@xxxxxxxxxx>
> Cc: Roman Gushchin <roman.gushchin@xxxxxxxxx>
> Cc: MengEn Sun <mengensun@xxxxxxxxxxx>
> Cc: "Thomas Weißschuh" <linux@xxxxxxxxxxxxxx>
> ---
> kernel/ucount.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/ucount.c b/kernel/ucount.c
> index 8686e329b8f2..f629db485a07 100644
> --- a/kernel/ucount.c
> +++ b/kernel/ucount.c
> @@ -199,7 +199,7 @@ void put_ucounts(struct ucounts *ucounts)
> }
> }
>
> -static inline bool atomic_long_inc_below(atomic_long_t *v, int u)
> +static inline bool atomic_long_inc_below(atomic_long_t *v, long u)
> {
> long c, old;
> c = atomic_long_read(v);
> --
> 2.50.1
>