Re: [PATCH] selftests/futex: Compile also on libnuma < 2.0.16

From: Thomas Gleixner
Date: Mon Jul 21 2025 - 13:23:07 EST


On Tue, Jul 15 2025 at 11:52, Sebastian Andrzej Siewior wrote:
> INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)
> -CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES)
> +CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES) -DLIBUNMA_VER_$(LIBNUMA_TEST)=1

LIBUNMA?

> int main(int argc, char *argv[])
> {
> struct futex32_numa *futex_numa;
> - int mem_size, i;
> + int mem_size, i __maybe_unused;

Why this unused muck?

> +#ifdef LIBUNMA_VER_SUFFICIENT
> for (i = 0; i < 4; i++) {

if you can just do

for (int i = 0; ...

?

Thanks,

tglx