RE: [PATCH v3] hfs: remove BUG() from hfs_release_folio()/hfs_test_inode()/hfs_write_inode()

From: Viacheslav Dubeyko
Date: Mon Jul 21 2025 - 13:04:41 EST


On Fri, 2025-07-18 at 07:08 +0900, Tetsuo Handa wrote:
> On 2025/07/18 4:49, Viacheslav Dubeyko wrote:
> > I assume if we created the inode as normal with i_ino == 0, then we can make it
> > as a dirty. Because, inode will be made as bad inode here [2] only if rec->type
> > is invalid. But if it is valid, then we can create the normal inode even with
> > i_ino == 0.
>
> You are right. The crafted filesystem image in the reproducer is hitting HFS_CDR_DIR with
> inode->i_ino = 0 ( https://elixir.bootlin.com/linux/v6.16-rc6/source/fs/hfs/inode.c#L363 ).

So, any plans to rework the patch?

Thanks,
Slava.