Re: [PATCH v4 12/14] rv: Replace tss and sncid monitors with more complete sts

From: Nam Cao
Date: Mon Jul 21 2025 - 11:15:51 EST


On Mon, Jul 21, 2025 at 10:23:22AM +0200, Gabriele Monaco wrote:
> The tss monitor currently guarantees task switches can happen only while
> scheduling, whereas the sncid monitor enforces scheduling occurs with
> interrupt disabled.
>
> Replace the monitors with a more comprehensive specification which
> implies both but also ensures that:
> * each scheduler call disable interrupts to switch
> * each task switch happens with interrupts disabled
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> fixup sts remove sncid

Is this here by accident?

I cannot comment on the model. The CONFIG_X86_LOCAL_APIC case looks
complex, but I cannot comment on that either.

But things look fine from RV perspective, so:
Acked-by: Nam Cao <namcao@xxxxxxxxxxxxx>