Re: [PATCH net-next 1/4] dt-bindings: net: document st,phy-wol property

[Gatien CHEVALLIER]

On 7/21/25 14:16, Krzysztof Kozlowski wrote:
> On 21/07/2025 14:10, Gatien CHEVALLIER wrote:
> > Hello Krzysztof,
> >
> > On 7/21/25 13:30, Krzysztof Kozlowski wrote:
> > > On 21/07/2025 13:14, Gatien Chevallier wrote:
> > > > The "st,phy-wol" property can be set to use the wakeup capability of
> > > > the PHY instead of the MAC.
> > >
> > >
> > > And why would that be property of a SoC or board? Word "can" suggests
> > > you are documenting something which exists, but this does not exist.
> > Can you elaborate a bit more on the "not existing" part please?
>
>
> Where does this property exist that you suggest that a new binding "can"
> use it?

I'm not sure if you're only targeting the wording here?

I found this property: "mediatek,mac-wol". Its non-presence sets the
same flag AFAICT.

I need to set the flag so that the stmmac_set_wol() in
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c eventually
reaches the PHY driver.

> > For the WoL from PHY to be supported, the PHY line that is raised
> > (On nPME pin for this case) when receiving a wake up event has to be
> > wired to a wakeup event input of the Extended interrupt and event
> > controller(EXTI), and that's implementation dependent.
>
>
> So it is not "can" but some implementations do not have proper wiring.
> You need to justify your commits and changes.

Ok, does:
In case of proper wiring from the PHY to a wake up event input,
set the "st,phy-wol" to indicate that the PHY WoL capability is
preferred over the MAC one.

seems better?

> Best regards,
> Krzysztof