Re: [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support

[Mark Brown]

On Mon, Jul 21, 2025 at 03:11:28PM +0800, Joy Zou wrote:

> The PF0900 is a power management integrated circuit (PMIC) optimized
> for high performance i.MX9x based applications. It features five high
> efficiency buck converters, three linear and one vaon regulators.
> It provides low quiescent current in Standby and low power off Modes.

This looks basically fine, one very minor issue since it looks like you
need to resubmit for the bindings:

> +static const struct regmap_config pf0900_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	.volatile_table = &pf0900_volatile_regs,
> +	.max_register = PF0900_MAX_REGISTER - 1,
> +	.cache_type = REGCACHE_RBTREE,
> +};

Unless you've got a strong reason to do something else new drivers
should use _MAPLE, it's a more modern data structure.

Attachment: signature.asc
Description: PGP signature