Re: [PATCH v3] module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to EXPORT_SYMBOL_FOR_MODULES

From: Vlastimil Babka
Date: Mon Jul 21 2025 - 06:43:47 EST


On 7/15/25 20:58, Daniel Gomez wrote:
> On 15/07/2025 10.43, Vlastimil Babka wrote:
>> Christoph suggested that the explicit _GPL_ can be dropped from the
>> module namespace export macro, as it's intended for in-tree modules
>> only. It would be possible to restrict it technically, but it was
>> pointed out [2] that some cases of using an out-of-tree build of an
>> in-tree module with the same name are legitimate. But in that case those
>> also have to be GPL anyway so it's unnecessary to spell it out in the
>> macro name.
>>
>> Link: https://lore.kernel.org/all/aFleJN_fE-RbSoFD@xxxxxxxxxxxxx/ [1]
>> Link: https://lore.kernel.org/all/CAK7LNATRkZHwJGpojCnvdiaoDnP%2BaeUXgdey5sb_8muzdWTMkA@xxxxxxxxxxxxxx/ [2]
>> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>> Reviewed-by: Shivank Garg <shivankg@xxxxxxx>
>> Acked-by: David Hildenbrand <david@xxxxxxxxxx>
>> Acked-by: Nicolas Schier <n.schier@xxxxxx>
>> Reviewed-by: Daniel Gomez <da.gomez@xxxxxxxxxxx>
>> Reviewed-by: Christian Brauner <brauner@xxxxxxxxxx>
>> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
>> ---
>> Daniel, please clarify if you'll take this via module tree or Christian
>> can take it via vfs tree?
>
> Patch 707f853d7fa3 ("module: Provide EXPORT_SYMBOL_GPL_FOR_MODULES() helper")
> from Peter was merged through Masahiro in v6.16-rc1. Since this is a related
> fix/rename/cleanup, it'd make sense for it to go through his kbuild tree as
> well. Masahiro, please let me know if you'd prefer otherwise. If not, I'll queue
> it up in the modules tree.

Maybe with no reply, you can queue it then?

Thanks,
Vlastimil