Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support
From: Christoph Hellwig
Date: Mon Jul 21 2025 - 03:21:06 EST
On Mon, Jul 21, 2025 at 08:42:40AM +0200, Thomas Weißschuh wrote:
> This would still leave the exports for replace_fd(), create_pipe_files()
> and set_fs_pwd(). Instead of using kernel/umh.c,
Please look into a way to just run your userspace tests from userspace.
It's not that hard, people have done this novel concept for at least
a few decades if you look into it.
> I can also extend
> kernel/usermode_driver.c to provide these in a way that works for me.
> But kernel/usermode_driver.c is dead code, unused since commit
> 98e20e5e13d2 ("bpfilter: remove bpfilter")
> Would it be fine to export those symbols? And delete usermode_driver.c,
> as carrying around an unused generic framework seems pointless.
Unused code should always go away. Weirdly enough USERMODE_DRIVER is
selected by BPF_PRELOAD despite that not really using any code from
it, though.