Re: [PATCH 00/16] Add support for the Axis ARTPEC-8 SoC
From: Krzysztof Kozlowski
Date: Mon Jul 21 2025 - 02:40:11 EST
On 21/07/2025 06:50, SeonGu Kang wrote:
> 2025-07-10 (목), 09:07 +0200, Krzysztof Kozlowski:
>> On 10/07/2025 02:20, ksk4725@xxxxxxxxxx wrote:
>>> From: SeonGu Kang <ksk4725@xxxxxxxxxx>
>>>
>>> Add basic support for the Axis ARTPEC-8 SoC.
>>> This SoC contains four Cortex-A53 CPUs and other several IPs.
>>>
>>> Patches 1 to 10 provide the support for the clock controller,
>>> which is similar to other Samsung SoCs.
>>>
>> You should explain here (and in DTS patches or the bindings) the
>> hardware, that this is Samsung SoC.
>>
>> You could also explain the differences from Exynos and proposed
>> handling
>> of patches (because this is odd)
>>
>> Also, entire patchset has wrong and incomplete SoBs. Your SoB is
>> missing
>> everywhere, others have wrong order.
>>
>> Please read submitting patches first.
>>
>
> This Custom SoC is owned by the Axis (OEM) and manufactured by the
> Samsung (ODM). It has standard Samsung specific IP blocks.
It is designed by Samsung. It is Samsung SoC.
Anyway, don't explain to me, but in your patchset.
Best regards,
Krzysztof