Re: [PATCH] media: stk1160: Restore deleted comment in stk1160_fill_urb()

[Xu Yang]

On Tue, Jul 15, 2025 at 06:00:32PM -0500, Dan Carpenter wrote:
> This comment explains why we return success when usb_alloc_noncoherent()
> fails and I think it's helpful.  It was deleted during a recent refactor,
> but let's add it back.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Xu Yang <xu.yang_2@xxxxxxx>

Thanks,
Xu Yang

> ---
>  drivers/media/usb/stk1160/stk1160-video.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/stk1160/stk1160-video.c b/drivers/media/usb/stk1160/stk1160-video.c
> index 416cb74377eb..3e6bffd49346 100644
> --- a/drivers/media/usb/stk1160/stk1160-video.c
> +++ b/drivers/media/usb/stk1160/stk1160-video.c
> @@ -408,8 +408,13 @@ static int stk1160_fill_urb(struct stk1160 *dev, struct stk1160_urb *stk_urb,
>  	stk_urb->transfer_buffer = usb_alloc_noncoherent(dev->udev, sb_size,
>  							 GFP_KERNEL, &stk_urb->dma,
>  							 DMA_FROM_DEVICE, &stk_urb->sgt);
> -	if (!stk_urb->transfer_buffer)
> +	if (!stk_urb->transfer_buffer) {
> +		/*
> +		 * If the buffer allocation failed, we exit but return 0 since
> +		 * we allow the driver working with less buffers.
> +		 */
>  		goto free_urb;
> +	}
>  
>  	stk_urb->dev = dev;
>  	return 0;
> -- 
> 2.47.2
>