Re: [PATCH] rtc: amlogic-a4: Optimize global variables

[Xianwei Zhao]

Hi Markus,
   Thanks for your advice.

On 2025/7/17 23:42, Markus Elfring wrote:
> [Some people who received this message don't often get email from markus.elfring@xxxxxx. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> > Use local variables struct regmap_config instread of global
>
>              variable?                      instead?
>
>
> > variables. The goal of saving memory has been achieve.
>
>                                                  achieved?
>
> You may occasionally put more than 59 characters into text lines
> of such a change description.
>
>
> …
> > ---
> > Use local variables struct regmap_config instread of global
> > variables.
> > ---
> >   drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
> …
>
> Please avoid duplicate information here.
>
>
> Can a summary phrase like “Convert a global variable into a local one
> of aml_rtc_probe()” be more appropriate?

Will do.

> Regards,
> Markus